This repository was archived by the owner on Aug 19, 2025. It is now read-only.
Allow string indexing into Record#501
Merged
aminalaee merged 3 commits intoencode:masterfrom Aug 3, 2022
Merged
Conversation
The Record interface inherits from Sequence which only supports integer indexing. The Postgres backend supports string indexing into Records (https://github.com/encode/databases/blob/master/databases/backends/postgres.py#L135). This PR updates the interface to reflect that. At least on the Postgres backend __getitem__ deserializes some data types, so it's not equivalent to the _mapping method.
aminalaee
reviewed
Jul 28, 2022
Contributor
Author
|
@aminalaee is there anything else you need from me? |
aminalaee
approved these changes
Aug 3, 2022
Contributor
aminalaee
left a comment
aminalaee
left a comment
There was a problem hiding this comment.
Thank you @circlingthesun for the contribution.
Contributor
Author
|
Thanks for reviewing and merging this @aminalaee 🙂 |
gaetano-guerriero
pushed a commit
to athenianco/morcilla
that referenced
this pull request
Feb 27, 2023
* Allow string indexing into Record The Record interface inherits from Sequence which only supports integer indexing. The Postgres backend supports string indexing into Records (https://github.com/encode/databases/blob/master/databases/backends/postgres.py#L135). This PR updates the interface to reflect that. At least on the Postgres backend __getitem__ deserializes some data types, so it's not equivalent to the _mapping method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Record interface inherits from Sequence which only supports integer indexing. The Postgres backend supports string indexing into Records (https://github.com/encode/databases/blob/master/databases/backends/postgres.py#L135). This PR updates the interface to reflect that.
At least on the Postgres backend getitem deserializes some data types, so it's not equivalent to the _mapping property.